Handle ClientError with code AccessDenied #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it is now handled the same as a NoCredentialsError Exception. Small refactor to avoid code duplication (it's a code smell)
|
👍 |
In die_unknown_error(), the error was sent to stdout. Now to stderr. Moved the tests: - test_missing_credentials - test_expired_credentials from test_cli to test_error_handling Added testcase in test_missing_credentials(). Added test_unknow_ClientError_no_stack_trace()
kenden
force-pushed
the
handle_access_denied
branch
from
72b99e8
to
d6da227
Compare
|
Thanks for checking @jmcs. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it is now handled the same as a NoCredentialsError Exception.
ClientError with code AccessDenied can happen when switching to another AWS role
(with
aws sts assume-role --role-arn...for example).If the token returned from that command expired, we get an accessdenied.
Small refactor to avoid code duplication.