Fix retries for ports that are in use (closes #38) #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hjacobs, the Travis CI setup seems to be broken. It's complaining about code I didn't even touch. The |
Previously, no exception was thrown if the server port was already in use. Therefore, the port assignment code in `zign.api` did not work as expected. Disallowing address re-use in `zign.oauth2.ClientRedirectServer` fixes this behavior. Additional changes: - Fix or ignore flake8 issues - Add test for zign.oauth2 module
|
👍 |
1 similar comment
|
👍 |
pmeinhardt
deleted the
bug/38-existing-port-binding-is-not-always-respected-when-choosing-a-local-port
branch
|
Do you have an idea when these changes will be released? 👋 🙂 |
|
@pmeinhardt released as 1.2: https://pypi.org/project/stups-zign/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #38
Previously, no exception was thrown if the server port was already in
use. Therefore, the port assignment code in
zign.apidid not work asexpected.
Disallowing address re-use in
zign.oauth2.ClientRedirectServerfixesthis behavior.
Additional changes: