Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore x- extensions on path obj, better error on missing operationId #525

Closed
wants to merge 3 commits into from
Closed

Ignore x- extensions on path obj, better error on missing operationId #525

wants to merge 3 commits into from

Conversation

pkeeper
Copy link

@pkeeper pkeeper commented Oct 10, 2017

Changes proposed in this pull request:

  • Ignore extensions on path objects. Apiary uses x-summary and x-description.
  • Better error handling when no operationId specified with default resolver.

@coveralls
Copy link

coveralls commented Oct 10, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.1%) to 99.86% when pulling dbc1708 on pkeeper:apiary-support into 94f64b8 on zalando:master.

@hjacobs
Copy link
Contributor

hjacobs commented Oct 11, 2017

@pkeeper thanks for the PR! Can you add appropriate unit tests? Thanks! 😄

@jmcs
Copy link
Contributor

jmcs commented Jul 10, 2018

@pkeeper are you still interested in merging this PR? If so please provide unit tests for this change.

@hjacobs
Copy link
Contributor

hjacobs commented Apr 25, 2020

I'm closing this PR for now (as it's pretty old).

@hjacobs hjacobs closed this Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
waiting contributor feedback
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pkeeper @coveralls @hjacobs @jmcs