Skip to content

Commit

Permalink
Merge pull request #237 from zalando/fewer-warnings
Browse files Browse the repository at this point in the history
stop overriding the warning level
  • Loading branch information
shansfolder committed Aug 21, 2018
2 parents ef6a46a + 62502b5 commit 4ab75fa
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
1 change: 0 additions & 1 deletion expan/core/experiment.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
from expan.core.statistical_test import *
from expan.core.results import StatisticalTestResult, MultipleTestSuiteResult, CombinedTestStatistics

warnings.simplefilter('always', UserWarning)
warnings.filterwarnings("ignore", category=FutureWarning)
logger = logging.getLogger(__name__)

Expand Down
2 changes: 1 addition & 1 deletion tests/tests_core/test_statistics.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
from expan.core.util import find_value_by_key_with_condition
from .util import *

warnings.simplefilter('always')

class StatisticsTestCase(unittest.TestCase):
def setUp(self):
Expand Down Expand Up @@ -202,7 +203,6 @@ class PooledStdTestCases(StatisticsTestCase):
def test__pooled_std__variances_differ_too_much_error(self):
""" Warning raised when variances differ too much. """
with warnings.catch_warnings(record=True) as w:
warnings.simplefilter('always')
statx.pooled_std(0.25, 4, 0.5, 4)
self.assertEqual(len(w), 1)
self.assertTrue(issubclass(w[-1].category, UserWarning))
Expand Down

0 comments on commit 4ab75fa

Please sign in to comment.