Bad code duplication in experiment.py

[gbordyugov]

Experiment.delta() is now a dispatcher, however those lines https://github.com/zalando/expan/blob/dev/expan/core/experiment.py#L368 duplicate the code https://github.com/zalando/expan/blob/dev/expan/core/experiment.py#L455

Additional complication: delta() function calls the other one, i.e. fixed_horizon_delta()

[chaitanyasd]

I'm a newbie. Can i take this? Please can you help.

[jbao]

@csdeshpande19 sure, this requires some de-duplication of the delta() and fixed_horizon_delta() function. Let us know if you have any specific questions.

[chaitanyasd]

Can you tell me what exactly I have to fix so i can start working on it.

[jbao]

My idea would be to remove the duplicated code in fixed_horizon_delta() and do all the pre-processing in delta(), but feel free to open a PR and maybe it would become easier to discuss. What do you think?

[chaitanyasd]

Yeah. No problem. I'll do a PR in few hours as I'm new to Open Source so it may take some time to get acquainted with it. I'll try to help as much as I can.

[s4826]

Does this still need to be done?

[jbao]

Hi @s4826 , yes, this one is still open AFAIK.

[s4826]

Ok, I'll open a pull request.