OCTO-2622: chi-square test for check of variant split #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 4, 2018 14:29
…ightly adapted compared to previous implementation
gbordyugov
reviewed
Jul 4, 2018
| :type x: pd.Series or array-like | ||
| :param y: sample of the control group | ||
| :type x: pd.Series or array-like | ||
| :param min_counts: minimum number of observed and expected frequencies (should be at least 5) |
There was a problem hiding this comment.
where does the number 5 come from?
There was a problem hiding this comment.
"This test is invalid when the observed or expected frequencies in each category are too small. A typical rule is that all of the observed and expected frequencies should be at least 5." - https://docs.scipy.org/doc/scipy-0.16.1/reference/generated/scipy.stats.chisquare.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is not ready for review yet: according use of the test should be implemented.
Chi-square test is checked and very slightly adapted compared to previous implementation.