Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 4eye principle for approving PRs #250

Merged
merged 2 commits into from
Sep 18, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 17 additions & 1 deletion .zappr.yaml
Original file line number Diff line number Diff line change
@@ -1 +1,17 @@
X-Zalando-Type: tools
X-Zalando-Team: octopus
X-Zalando-Type: code

approvals:
minimum: 2
# approval = comment that matches this regex
pattern: "^(:\\+1:|👍)"
# note that `from` is by default empty,
# accepting any matching comment as approval
from:
# commenter must be either one of:
orgs:
# a public zalando org member
# (any org in here counts)
- zalando
# OR a collaborator of the repo
collaborators: true
1 change: 1 addition & 0 deletions AUTHORS.rst → CONTRIBUTORS.rst
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ Development Lead
Contributors
------------

* Aaron McDaid <aaron.mcdaid@zalando.de>
* Darya Dedik <darya.dedik@zalando.de>
* Dominic Heger <dominic.heger@zalando.de>
* Grigory Bordyugov <grigory.bordyugov@zalando.de>
Expand Down
4 changes: 4 additions & 0 deletions MAINTAINERS.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
aaron.mcdaid@zalando.de
darya.dedik@zalando.de
grigory.bordyugov@zalando.de@zalando.de
shan.huang@zalando.de