Skip to content
This repository has been archived by the owner on Nov 3, 2021. It is now read-only.

make kms decryption region a parameterised information #83

Closed
lotharschulz opened this issue Apr 9, 2018 · 1 comment
Closed

make kms decryption region a parameterised information #83

lotharschulz opened this issue Apr 9, 2018 · 1 comment
Labels
enhancement help wanted

Comments

@lotharschulz
Copy link
Contributor

remove hard coded AWS region:
https://github.com/zalando/ghe-backup/blob/master/convert-kms-private-ssh-key.sh#L36
@rashamalek
Copy link
Contributor

based on Instance Identity Documents
we can extract an instance using document endpoint

REGION=`curl http://169.254.169.254/latest/dynamic/instance-identity/document | grep region | awk -F\" '{print $4}'`
sed  "s/eu-central-1/$REGION/g" /kms/convert-kms-private-ssh-key_original.sh

Simple and quickest solution would be to replace it in the /kms/convert-kms-private-ssh-key.sh file using sed

rashamalek pushed a commit that referenced this issue Apr 17, 2018
issue #83 kms decryption region independent
ae4d65a
@rashamalek rashamalek mentioned this issue Apr 17, 2018
Merged
lotharschulz pushed a commit that referenced this issue May 23, 2018
@rashamalek @lotharschulz
issue #83 kms decryption region independent (#84)
75003d8 
* issue #83 kms decryption region independent
This was referenced May 23, 2018
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lotharschulz @rashamalek