Fix Windows crash by bumping wincred #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! @mislav |
|
Ah no close/reopen does not work, you have to fetch and rebase on master branch. |
For some Go applications, reading a stored credential from wincred could result in a crash because both the returned credential pointer and the error value would be nil, even though the credential technically exists in wincred storage. This was fixed upstream in the wincred library. Signed-off-by: Mislav Marohnić <git@mislav.net>
mikkeloscar
force-pushed
the
windows-crash
branch
from
9c5997d
to
93ba584
Compare
|
I have rebased the PR |
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some Go applications, reading a stored credential from wincred could result in a crash because both the returned credential pointer and the error value would be nil, even though the credential technically exists in wincred storage. This was fixed upstream in the wincred library.
danieljoos/wincredis now 1.18. The appveyor build fails as a result due to its go versiongo1.13.3Fixes #53