Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completion for enumerated values #30

Closed
viatra2 opened this issue May 29, 2016 · 0 comments
Closed

Completion for enumerated values #30

viatra2 opened this issue May 29, 2016 · 0 comments
Assignees
@semonte
Labels
enhancement

Comments

@viatra2
Copy link
Contributor

viatra2 commented May 29, 2016

Consider the screenshot:
screen shot 2016-05-29 at 13 43 10

The set of values for parameter#in is enumerated, it should be suggested here (specifically query should be the only value matched by qu).

There is already existing @Ingore test in CaretCompletionTest#enumValuesCompletion_ParametersIn for this.
semonte pushed a commit that referenced this issue May 30, 2016
@viatra2 @semonte
Fixed #25, + tests refactoring + added tests for #22, #21, #30 (#28)
75eef24 
* tests refactoring before fixing #25 (part 1 of 3)

- no changes, just restructuring
- insert value tests moved to separate test data folder / separate test fixture to simplify naming

* tests refactoring before fixing #25 (part 2 of 3)

- no changes, just restructuring
- insert field tests moved to separate test data folder
- avoid useless subfolder (/values) leaking into the configured test project for /fields
- allows to remove prefixes 'field_' / 'value_' in test data file names

* tests refactoring before fixing #25 (part 3 of 3)

- field_ prefix for test data files under /field folder is now useless, removed

* tests refactoring before fixing #25 (part 3 of 3)

- value_ prefix for test data files under /value folder is now useless, removed
- to be later removed to 'reference' (?)

* tests refactoring before fixing #25

- AbstractJsonOrYamlCompletionTest introduced to avoid copy-pasted code

* tests refactoring before fixing #25

- test data for $ref values completion renamed: "string_" -> "ref_"

* failing tests added for #25 and #22

- marked as @ignore until actual fix

* fixes #25: $ref value completion to respect '/' and '#' as already entered prefixes

* tests for #25 now pass

 - removed @ignore
 - added more checks for prefixes with midway non-java-id chars

* more failing tests added

- test for #21 (boolean value completion) added, now fails, @ignore'd
- test for #30 (enumerated values completion): existing old test linked to the issue, still fails, @ignore'd
@semonte semonte modified the milestones: 0.0.6, 0.0.7 May 30, 2016
@semonte semonte removed this from the 0.0.7 milestone Jun 8, 2016
@semonte semonte self-assigned this Jun 8, 2016
@semonte semonte closed this as completed in 5454a72 Jun 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@semonte semonte

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@semonte @viatra2