Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore CurrencyUnitDeserializer? #67

Closed
sappenin opened this issue Sep 8, 2017 · 5 comments
Closed

Restore CurrencyUnitDeserializer? #67

sappenin opened this issue Sep 8, 2017 · 5 comments
Assignees

Comments

@sappenin
Copy link

sappenin commented Sep 8, 2017

Any reason CurrencyUnitDeserializer was removed in the 9/1 commit?

It would be nice to use this library to serialize/deserialize standalone fields of type javax.money.CurrencyUnit.

@whiskeysierra
Copy link
Collaborator

We removed it in an attempt to reduce the public API to a workable minimum. I did this under the assumption that de/serializing MonetaryAmount instances is the primary if not even the only use case. I guess I was wrong. I'll re-create the support for CurrencyUnit.

@sappenin
Copy link
Author

Awesome - thanks for being open to the request! In my case, I have an API that's advertising a currency unit by itself.

@whiskeysierra
Copy link
Collaborator

@sappenin Feel free to take a look at #68.

@sappenin
Copy link
Author

Looks great, thanks!

@whiskeysierra
Copy link
Collaborator

@sappenin I released 1.0.0-RC2 to central just now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants