Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logbook-spring-boot-autoconfigure in 3.0.0-RC.2 is using org.zalando:logbook-httpclient dependency #1491

Closed
marcindabrowski opened this issue May 4, 2023 · 1 comment
Labels

Comments

@marcindabrowski
Copy link

Description

In logbook-spring-boot-autoconfigure pom.xml there islogbook-httpclient dependency.

Expected Behavior

Support for Apache HttpClient 4 has been removed in Spring Framework 6.0, and replaced with Apache HttpClient 5.

Because of that logbook-httpclient should not be added as a default dependency to logbook-spring-boot-autoconfigure.

Actual Behavior

The below dependency is present in logbook-spring-boot-autoconfigure pom.xml.

<dependency>
  <groupId>org.zalando</groupId>
  <artifactId>logbook-httpclient</artifactId>
</dependency>

Possible Fix

logbook-httpclient dependency should be removed from logbook-spring-boot-autoconfigure pom.xml.

Your Environment

  • Version used: 3.0.0-RC.2
@kasmarian
Copy link
Member

Hi @marcindabrowski, logbook-httpclient will be optional starting from the next release version. Thank you for highlighting this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants