ServletInputStreamAdapter do not implement ServletInputStream abstract class methods for servlet 3.1 and above

[shantanugithub]

Why doesn't ServletInputStreamAdapter implement ServletInputStream abstract class methods for servlet 3.1 and above ?

ServletInputStreamAdapter do not implement ServletInputStream abstract class methods (setReadListener() and isReady()) for servlet 3.1 and above. I use logbook for req/res logging in my spring boot application (1.5.3.RELEASE) which uses tomcat 8.5
My question is whether using zalando logbook in my code will hamper the NIO capability of my tomcat application ?

[whiskeysierra]

We're using servlet api 3.1.1 as a dependency and I can't see those methods anywhere.

[shantanugithub]

@whiskeysierra
Please check this documentation : https://docs.oracle.com/javaee/7/api/javax/servlet/ServletInputStream.html

[whiskeysierra]

Interesting. Looks like the glassfish version of the jar doesn't contain the proper classes. I'll try to prepare a fix.

[shantanugithub]

👍

[shantanugithub]

@whiskeysierra Any update on the fix ?

[whiskeysierra]

Sorry, my schedule is pretty packed at the moment. Do you mind preparing a pull request?

[bcole]

I think we might be running into this same issue, our requests are not completing when I turn on Logbook.

Anyone have a fix for this?