Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove compacting functionality from json formatter #361

Closed
whiskeysierra opened this issue Oct 8, 2018 · 0 comments · Fixed by #442
Closed

Remove compacting functionality from json formatter #361

whiskeysierra opened this issue Oct 8, 2018 · 0 comments · Fixed by #442
Milestone
2.0.0

Comments

@whiskeysierra
Copy link
Collaborator

Detailed Description

Due to #357 the compacting feature is now part of individual body filters, rather than specific formatter implementations.

Context

  • Promotes body filters that are easier to combine/reuse
  • Removes code duplications

Possible Implementation

  • Remove compacting from JsonHttpLogFormatter
  • Register compacting json body filter by default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

Extracted compacting from JsonHttpLogFormatter zalando/logbook
1 participant
@whiskeysierra