Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split up formatting and writing #5

Closed
whiskeysierra opened this issue Sep 28, 2015 · 1 comment
Closed

Split up formatting and writing #5

whiskeysierra opened this issue Sep 28, 2015 · 1 comment

Comments

@whiskeysierra
Copy link
Collaborator

Right now the HttpLogger implementations do both, formatting the request/response data into some kind of text format and they also choose a concrete target for the data, usually a Slf4j Logger.

If we split those responsibilities up into two interfaces we could more easily add support for one of those concerns without changing the other.

As correctly mentioned by @lukasniemeier-zalando this could also mean we extract the condition (shouldLog) from the interface.

@lukasniemeier-zalando
Copy link
Member

👍 maybe we should take the chance and easen the creation of the creation of a fully configured LoggingFilter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants