Refactored library completely

[whiskeysierra]

• got rid of Spring dependency (see Get rid of Spring dependency #4)
• fixed async dispatch support (see Servlet 3 asynchronous requests not correctly handled #2)
• refactored API to split up formatting and writing (see Split up formatting and writing #5)

I renamed the project to Logbook in the process. Still missing:

• support for obfuscators (headers, parameters, body)
• ~50% code coverage
• logo for readme

[lukasniemeier-zalando]

• I'd stick with obfuscate the body as a String
• You need to insert you as a (or the) maintainer 😛

[whiskeysierra]

I'd stick with obfuscate the body as a String

Absolutely, I'd just think about having a different interface for the body (without the fake key):

String obfuscate(final String body);

vs.

String obfuscate(final String key, final String value);

[whiskeysierra]

I'd just think about having a different interface for the body

Otherwise I have the fear that clients, without reading the docs properly, would just look at the method having a key and a value and would assume that a body obfuscator would get called for every property + value (e.g. for json).

[lukasniemeier-zalando]

👍 obfuscation of the body will surely be also very different from obfuscating a header/parameter implementation-wise

[whiskeysierra]

Any idea whether this is safe to use as a wallpaper?
https://en.wikipedia.org/wiki/File:Grand_Turk(34).jpg

[jhorstmann]

I don't see the need for having this as an interface with default methods instead of protected methods in OnceFilter. Default methods are nice if a subclass might have a more optimized implementation, but here it just makes the code harder to follow.

[whiskeysierra]

but here it just makes the code harder to follow.

I inlined most of them now (not pushed yet).

[jhorstmann]

Are you using lombok just for one SneakyThrows or did I miss any more usages?

[whiskeysierra]

Are you using lombok just for one SneakyThrows or did I miss any more usages?

This is the only usage right here. I haven't check if it actually helps to get full coverage.

[bocytko]

Would it make sense to extract lines 45-51 as they're equal to 66-72?

[whiskeysierra]

👍