Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only include zalando loogbook dependencies in logbook-bom #1160

Merged
merged 2 commits into from
Sep 27, 2021
Merged

Only include zalando loogbook dependencies in logbook-bom #1160

merged 2 commits into from
Sep 27, 2021

Conversation

aschugunov
Copy link
Contributor

@aschugunov aschugunov commented Sep 20, 2021

Description

root pom.xml contains the only list of modules and common description
logbook-parent contains <dependencyManagement/>, <properties/> and etc. from previous root pom
logbook-bom does not have a dependency on the parent module with its own import of dependencies
Version of kotlin-maven-plugin was added

Motivation and Context

resolves #1086

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@whiskeysierra
Copy link
Collaborator

@aschugunov Thank you for contributing! 📣 Can you rebase onto master to resolve the conflict?

@whiskeysierra
Copy link
Collaborator

👍

@whiskeysierra
Copy link
Collaborator

@aschugunov I'm sorry, there is another conflict. I merged PRs in the wrong order...

@aschugunov
Copy link
Contributor Author

aschugunov commented Sep 24, 2021

@aschugunov I'm sorry, there is another conflict. I merged PRs in the wrong order...

Don't worry :)

I found out dependabot updates version in a little bit ugly way
actually there are two different versions like spring-boot1 and spring-boot2 but dependabot updates only one
So I guess it should be resolved in another issue

@whiskeysierra
Copy link
Collaborator

👍

@whiskeysierra whiskeysierra merged commit 9805685 into zalando:main Sep 27, 2021
@whiskeysierra
Copy link
Collaborator

@aschugunov Thank you for your contribution, much appreciated! 📣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only include zalando loogbook dependencies in logbook-bom
2 participants