Fixed IllegalStateException when accessing AsyncContext #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds like you had fun 👍 |
whiskeysierra
added a commit
that referenced
this pull request
Oct 9, 2015
Fixed IllegalStateException when accessing AsyncContext
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that
ServletRequest.getAsyncContext()by contract is supposed to throw anIllegalStateExceptionif no async process was started. I just usedrequest.getAsyncContext() == nullto see if the current filter pass was a part of an async dispatch. Coincidentally Tomcat doesn't adhere to the spec here and actually returns null, which made it look like it worked. Testing it with Undertow though showed the problem.Additionally Spring MockMvc doesn't generate a true async dispatch request; the dispatcher type was still set to
REQUEST. Fun stuff...