Migrate to Spring 6 / Spring Boot 3

[msdousti]

Bumping version of Spring to 6, Spring Boot to 3, and using jakarta.* instead of javax.* in most places. This is a breaking change, as it drops support for previous versions. See Description for further info.

Description

Migrate Logbook to exclusively use Spring 6 / Spring Boot 3. That is, we drop support for Spring 5.x or Spring Boot 2.x.
It is yet to be decided whether we want to drop this support, so this PR is provided on a just-in-case basis.

Motivation and Context

Fixes #1344

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
  • Some changes to the documentation are required. They will be applied once we make sure that we want to proceed with this approach.
• I have added tests to cover my changes.

[kasmarian]

Should we fallback to the same status on every implementation? I wouldn't say I like that in some modules it falls back to 200, but could a common practice. Or we could fallback to -1 as a way to say "no data" provided.

I can't say I'm a fan of the idea that a logging library can fail requests because one of the attributes (even the one that's probably always there) is missing.

[msdousti]

We should definitely discuss it. I also thought about changing the interface to return Integer instead of int, but didn't consider its implications.

[msdousti]

FYI: Tried my approach (Integer instead of int) and failed: One of the classes implements a Spring interface which has public int getStatus(), and extends a class which would then have public Integer getStatus(), and bam! clash.

I don't like default 200 either (because it can be misleading), and would like to see some fallback like -1 as you suggested.

[kasmarian]

Checked on a simple webflux app and works like a charm 🥳

[darrenskywalker]

Any ETA or update on when this PR might be merged in? I'm really looking forward to being able to use this library in SpringBoot 3 / Spring 6

[msdousti]

@darrenskywalker

Any ETA or update on when this PR might be merged in? I'm really looking forward to being able to use this library in SpringBoot 3 / Spring 6

Thanks a lot for the interest in Logbook! We are considering several approaches to add this support. While two working PRs exist, the decision in which way to go is yet to be made.

We need some time to discuss this and make the best decision to support our users.

Please have a look at the discussion I opened here:
#1426

[darrenskywalker]

@darrenskywalker

Any ETA or update on when this PR might be merged in? I'm really looking forward to being able to use this library in SpringBoot 3 / Spring 6

Thanks a lot for the interest in Logbook! We are considering several approaches to add this support. While two working PRs exist, the decision in which way to go is yet to be made.

We need some time to discuss this and make the best decision to support our users.

Please have a look at the discussion I opened here: #1426

Thanks @msdousti , that makes sense and thanks for the explanation and update.

[msdousti]

@owebb98
I remember I had issues when I tried to run tests for Logbook (not just this branch) on a Windows machine.
However, it worked fine on Mac, and also on Linux.

Checked on a simple webflux app and works like a charm 🥳

Hi! How did you do the build to test this? I've cloned the repo and checked out this branch but unit tests + build are failing via IntelliJ Ultimate. I can skip the tests but the build fails with "package org.zalando.logbook.httpclient5 does not exist" @ logbook-spring-boot-autoconfigure\src\main\java\org\zalando\logbook\autoconfigure\LogbookAutoConfiguration.java:336:44

Please let me know if you came across this during your testing.

Cheers!

[hemju]

@msdousti could you please give us an ETA when this will be fixed? I do understand that there needs to be decisions made, but the discussions started months ago and Spring Boot 3 was in November (with years of knowledge that javax will be removed).

[msdousti]

I'm closing this branch as the team decided against it: Logbook will keep support for older version of Spring, and add support for the new version as well.

As for an ETA, I unfortuantely can't make an estimation. I know it's frustrating, but I ask for your understanding.