Call close() on closeable ClientHttpResponse within BufferingClientHttpResponseWrapper.java #1665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clear resources
bobross-pg
requested review from
whiskeysierra and
lukasniemeier-zalando
as code owners
kasmarian
reviewed
Nov 7, 2023
| @@ -48,7 +48,9 @@ public void close() { | |||
| } catch (IOException e){ | |||
| throw new RuntimeException(e); | |||
| } | |||
| delegate.close(); | |||
| finally { | |||
| delegate.close(); | |||
There was a problem hiding this comment.
That's a really nice catch, @bobross-pg ! Would you also add a test for this scenario? So that we don't hit regression in future.
|
I will use a different github account, redo PR with with signed commits, how can I refuse/close this PR ? |
|
Found the button to close :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clear resources
Description
On exception and close operation, only 1 of 2 close-able resources are closed.
Motivation and Context
It looks like it could lead to memory leak.
Types of changes
Checklist: