Added support for JsonHttpLogger #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -28,7 +28,7 @@ | |||
| import java.util.List; | |||
| import java.util.Map; | |||
|
|
|||
| public class DefaultHttpLogger implements HttpLogger { | |||
| public final class DefaultHttpLogger implements HttpLogger { | |||
There was a problem hiding this comment.
Why final?
Because it's not intended to be subclassed, is it? If somebody needs stuff from it he/she is free to use composition.
There was a problem hiding this comment.
You never know what crazy things clients of the library want to do, maybe they want to extend this class - so why prevent it?
There was a problem hiding this comment.
In that case they should open a pull request and give a good reason for the change :)
whiskeysierra
added a commit
that referenced
this pull request
Sep 24, 2015
Added support for JsonHttpLogger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.