Jackson-based body filter for JSON #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjolber
requested review from
AlexanderYastrebov,
lukasniemeier-zalando and
whiskeysierra
as code owners
skjolber
force-pushed
the
jsonFilter
branch
2 times, most recently
from
4cb1bcf
to
dae2529
Compare
logbook-json/src/main/java/org/zalando/logbook/json/JacksonJsonFieldBodyFilter.java
Outdated
Show resolved
Hide resolved
logbook-json/src/main/java/org/zalando/logbook/json/JacksonJsonFieldBodyFilter.java
Outdated
Show resolved
Hide resolved
logbook-json/src/main/java/org/zalando/logbook/json/JacksonJsonFieldBodyFilter.java
Outdated
Show resolved
Hide resolved
logbook-json/src/main/java/org/zalando/logbook/json/JacksonJsonFieldBodyFilter.java
Outdated
Show resolved
Hide resolved
skjolber
force-pushed
the
jsonFilter
branch
2 times, most recently
from
66db085
to
7f16cf3
Compare
logbook-json/src/main/java/org/zalando/logbook/json/JacksonJsonFieldBodyFilter.java
Outdated
Show resolved
Hide resolved
logbook-json/src/main/java/org/zalando/logbook/json/JacksonJsonFieldBodyFilter.java
Outdated
Show resolved
Hide resolved
|
|
||
| return writer.toString(); | ||
| } catch(Exception e) { | ||
| log.trace("Unable to filter body, is it a JSON?. Keep as-is. `{}`", e.getMessage()); |
There was a problem hiding this comment.
Message doesn't really match what's happening.
|
👍 |
|
Thanks for the contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New JSON body filter.
Description
Add filter which uses Jackson to parse/serialize when filtering JSON. Supports both scalar values (i.e. string, number, boolean etc) and structures (tree, object).
Motivation and Context
Remove sensitive information (GDPR) and also cut down on log statement size (we're using stackdriver and there is a limit on statement size).
Types of changes
Checklist: