Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse Jackson JsonFactory, as it is thread safe #544

Merged
merged 2 commits into from Jul 5, 2019

Conversation

skjolber
Copy link
Contributor

Reuse Jackson JsonFactory.

Description

From JsonFactory Javadoc:

  • Factory instances are thread-safe and reusable after configuration
  • (if any). Typically applications and services use only a single
  • globally shared factory instance, unless they need differently
  • configured factories. Factory reuse is important if efficiency matters;
  • most recycling of expensive construct is done on per-factory basis.

Motivation and Context

Improve performance.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@skjolber
Copy link
Contributor Author

Build breaks on

One or more dependencies were identified with known vulnerabilities in Logbook: JSON:
jackson-databind-2.9.9.jar (cpe:/a:fasterxml:jackson:2.9.9, cpe:/a:fasterxml:jackson-databind:2.9.9, com.fasterxml.jackson.core:jackson-databind:2.9.9) : CVE-2019-12814

As there is no 2.9.10 release yet; add to csv-suppresions, or wait?

@whiskeysierra
Copy link
Collaborator

As there is no 2.9.10 release yet; add to csv-suppresions, or wait?

Suppress it for now.

I'm still waiting for FasterXML/jackson-databind#2341

@whiskeysierra
Copy link
Collaborator

👍

@whiskeysierra whiskeysierra merged commit 259dbbd into zalando:master Jul 5, 2019
@whiskeysierra
Copy link
Collaborator

Thanks for the contribution 🎉 and sorry that it took so long.

@skjolber skjolber deleted the reuseJsonFactory branch July 5, 2019 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants