Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added property predicate to JSON filters #655

Merged
merged 1 commit into from Dec 3, 2019
Merged

Added property predicate to JSON filters #655

merged 1 commit into from Dec 3, 2019

Conversation

whiskeysierra
Copy link
Collaborator

@whiskeysierra whiskeysierra commented Dec 2, 2019 •
edited

Description

Motivation and Context

Fixes #652

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@whiskeysierra whiskeysierra mentioned this pull request Dec 2, 2019
Closed
@fatroom
Copy link
Member

fatroom commented Dec 3, 2019

👍

@whiskeysierra whiskeysierra merged commit 550fc3c into master Dec 3, 2019
@whiskeysierra whiskeysierra deleted the feature/property-predicate branch December 3, 2019 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderYastrebov AlexanderYastrebov Awaiting requested review from AlexanderYastrebov

@lukasniemeier-zalando lukasniemeier-zalando Awaiting requested review from lukasniemeier-zalando

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make replaceJsonStringProperty regexp more general
2 participants
@whiskeysierra @fatroom