Respond with status 400 for invalid requests handled by spring security firewall #1260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spring firewall returns 500 when RequestRejectedException is thrown. The correct status code is 400. This is going to be addressed by spring-projects/spring-security#7568
adyach
reviewed
Feb 9, 2021
| import org.springframework.stereotype.Component; | ||
| import javax.servlet.http.HttpServletResponse; | ||
|
|
||
| @Aspect |
There was a problem hiding this comment.
i am not against aspects, but i am not really comfortable with it and it is not used in the project. maybe we could try to avoid using it.
There was a problem hiding this comment.
@adyach I have addressed your comment. I kept the same approach by intercepting doFilter method, but now the implementation is a Bean.
a1exsh
reviewed
Feb 10, 2021
| } catch (RequestRejectedException e) { | ||
| HttpServletResponse response = (HttpServletResponse) res; | ||
|
|
||
| response.sendError(HttpServletResponse.SC_NOT_FOUND); |
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spring firewall returns 500 when RequestRejectedException is thrown. The correct status code is 400.
This is going to be addressed by spring-projects/spring-security#7568
Review