add new module for kotlin extensions #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piyushmor
requested review from
AlexanderYastrebov,
lukasniemeier-zalando,
pc-alves,
whiskeysierra and
zeitlinger
as code owners
piyushmor
force-pushed
the
add-kotlin-extensions
branch
6 times, most recently
from
99b11bb
to
c23c581
Compare
opentracing-kotlin/src/main/kotlin/org/zalando/opentracing/kotlin/TracerExtension.kt
Outdated
Show resolved
Hide resolved
opentracing-kotlin/src/main/kotlin/org/zalando/opentracing/kotlin/TracerExtension.kt
Show resolved
Hide resolved
opentracing-kotlin/src/main/kotlin/org/zalando/opentracing/kotlin/TracerExtension.kt
Outdated
Show resolved
Hide resolved
opentracing-kotlin/src/main/kotlin/org/zalando/opentracing/kotlin/TracerExtension.kt
Outdated
Show resolved
Hide resolved
opentracing-kotlin/src/main/kotlin/org/zalando/opentracing/kotlin/TracerExtension.kt
Outdated
Show resolved
Hide resolved
opentracing-kotlin/src/main/kotlin/org/zalando/opentracing/kotlin/TracerExtension.kt
Outdated
Show resolved
Hide resolved
opentracing-kotlin/src/main/kotlin/org/zalando/opentracing/kotlin/TracerExtension.kt
Outdated
Show resolved
Hide resolved
opentracing-kotlin/src/main/kotlin/org/zalando/opentracing/kotlin/TracerExtension.kt
Outdated
Show resolved
Hide resolved
opentracing-kotlin/src/main/kotlin/org/zalando/opentracing/kotlin/TracerExtension.kt
Outdated
Show resolved
Hide resolved
opentracing-kotlin/src/main/kotlin/org/zalando/opentracing/kotlin/TracerExtension.kt
Outdated
Show resolved
Hide resolved
opentracing-kotlin/src/main/kotlin/org/zalando/opentracing/kotlin/TracerExtension.kt
Outdated
Show resolved
Hide resolved
opentracing-kotlin/src/main/kotlin/org/zalando/opentracing/kotlin/TracerExtension.kt
Outdated
Show resolved
Hide resolved
opentracing-kotlin/src/main/kotlin/org/zalando/opentracing/kotlin/TracerExtension.kt
Outdated
Show resolved
Hide resolved
piyushmor
force-pushed
the
add-kotlin-extensions
branch
2 times, most recently
from
8b81d85
to
dbc39a1
Compare
piyushmor
force-pushed
the
add-kotlin-extensions
branch
3 times, most recently
from
3d8717f
to
928ab73
Compare
zeitlinger
reviewed
Oct 28, 2020
opentracing-kotlin/src/main/kotlin/org/zalando/opentracing/kotlin/TracerExtension.kt
Outdated
Show resolved
Hide resolved
piyushmor
force-pushed
the
add-kotlin-extensions
branch
2 times, most recently
from
29f3eb2
to
af822e1
Compare
opentracing-kotlin/src/main/kotlin/org/zalando/opentracing/kotlin/TracerExtension.kt
Outdated
Show resolved
Hide resolved
opentracing-kotlin/src/main/kotlin/org/zalando/opentracing/kotlin/TracerExtension.kt
Show resolved
Hide resolved
|
👍 |
piyushmor
force-pushed
the
add-kotlin-extensions
branch
from
d7b878d
to
7501b82
Compare
|
👍 |
piyushmor
force-pushed
the
add-kotlin-extensions
branch
from
7501b82
to
a27cdb0
Compare
|
👍 |
|
@whiskeysierra do you know hot to resolve "The base branch requires all commits to be signed."? |
|
You need to sign all commits using gpg. There should be a link there how to
do it.
…On Mon, 2 Nov 2020, 16:06 Gregor Zeitlinger, ***@***.***> wrote:
@whiskeysierra <https://github.com/whiskeysierra> do you know hot to
resolve "The base branch requires all commits to be signed."?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#472 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADI7HMRBLCBDH6QLWIDXMTSN3DIFANCNFSM4S77YS5Q>
.
|
piyushmor
force-pushed
the
add-kotlin-extensions
branch
from
a27cdb0
to
a09ea1b
Compare
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new module that adds a few kotlin extension functions for the opentracing
Tracer.Motivation and Context
Kotlin developers can now benefit from less boiler plate code while enabling tracing.
Types of changes
Checklist: