First draft to support stacked listeners #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whiskeysierra
force-pushed
the
feature/stacked-trace-listener
branch
from
e6ef523
to
e4c3152
Compare
whiskeysierra
force-pushed
the
feature/stacked-trace-listener
branch
from
8606d60
to
d5c4484
Compare
JonasJurczok
reviewed
Oct 7, 2016
| @@ -0,0 +1,23 @@ | |||
| package org.zalando.tracer; | |||
|
|
|||
| import org.zalando.tracer.TracerFactory.Builder; | |||
There was a problem hiding this comment.
It's used as a link in the javadoc comment
There was a problem hiding this comment.
Ah ok. I didn't check that.. :)
JonasJurczok
reviewed
Oct 7, 2016
|
|
||
| /** | ||
| * {@link StackedTraceListener} are a special kind of {@link TraceListener}, because they are aware of | ||
| * {@link Builder#stacked() trace stacking}. A stacked trace will, in contract to {@link TraceListener}, be observed |
JonasJurczok
reviewed
Oct 7, 2016
| this.listeners = listeners; | ||
|
|
||
| final Map<Boolean, List<TraceListener>> partitions = listeners.stream() | ||
| .collect(partitioningBy(StackedTraceListener.class::isInstance)); |
There was a problem hiding this comment.
You sir are crazy :D
Nice.
There was a problem hiding this comment.
This is how partitioningBy is meant to be used, imho.
There was a problem hiding this comment.
Its awesome. I really like it :)
|
Looks good to me :) |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #56