Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple non-matching CRD definitions #1737

Closed
apeschel opened this issue Jan 10, 2022 · 0 comments · Fixed by #1781
Closed

Multiple non-matching CRD definitions #1737

apeschel opened this issue Jan 10, 2022 · 0 comments · Fixed by #1781

Comments

@apeschel
Copy link
Contributor

apeschel commented Jan 10, 2022

Please, answer some short questions which should help us to understand your problem / question better?

  • Which image of the operator are you using? e.g. registry.opensource.zalan.do/acid/postgres-operator:v1.7.1
  • Where do you run it - cloud or metal? Kubernetes or OpenShift? AWS K8s | Azure
  • Are you running Postgres Operator in production? yes
  • Type of issue? Bug Report

There are two locations in this repository where CRDs are defined:

  1. https://github.com/zalando/postgres-operator/tree/master/charts/postgres-operator/crds
  2. https://github.com/zalando/postgres-operator/tree/master/manifests

However, it seems that the CRDs in the second location have not been maintained. The operatorconfiguration CRD is missing the enable_cross_namespace_secret key. As a result, the CRD defined in /manifests is not compatible with either the 1.7.0 or 1.7.1 release.

https://github.com/zalando/postgres-operator/blob/master/manifests/operatorconfiguration.crd.yaml
https://github.com/zalando/postgres-operator/blob/master/charts/postgres-operator/crds/operatorconfigurations.yaml

$ diff manifests/operatorconfiguration.crd.yaml charts/postgres-operator/crds/operatorconfigurations.yaml
4a5,6
>   labels:
>     app.kubernetes.io/name: postgres-operator
175a178,180
>                   enable_cross_namespace_secret:
>                     type: boolean
>                     default: false
391,392d395
<                   wal_az_storage_account:
<                     type: string
396a400,401
>                   wal_az_storage_account:
>                     type: string

Perhaps a symlink could be used to ensure there is only a single copy of these files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant