Unify CRD Definitions #1738
Closed
Unify CRD Definitions #1738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apeschel
requested review from
CyberDem0n,
FxKu,
Jan-M and
sdudoladov
as code owners
|
Fixes #1737 |
There are duplicate CRD definitions in the Chart and Manifests directories. This commit changes the manifests files into symlinks and points them at the chart. It also matches the filename in both the manifests and charts directories.
apeschel
force-pushed
the
topic/apeschel/crd-fix
branch
from
7365d06
to
8373744
Compare
|
Seems to |
|
@apeschel I've synced it now manually. Would also agree that we should not make the charts the source of truth, but the other way around. At some point, somebody might want to template them as well (see #1779). But anyway, thanks for bringing it up and contributing. Sorry for being silent on this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are duplicate CRD definitions in the Chart and Manifests
directories. This commit changes the manifests files into symlinks and
points them at the chart. It also matches the filename in both the
manifests and charts directories.