major version upgrade for rootless and ocp : solving #1689

[neelasha-09]

We tested the solution in 3 places

1. Openshift (with reduced perms)
2. AWS (with access runAsNonRoot: false )
3. Pure Vanila k8s

At this stage, we cannot change spilo image instead.
Reason: PGO does not call a wrapper shell script (sh), but directly the python process. If it were a shell, we could have added this logic there. But now, it's too late, and only place to do it at this time is PGO.

The solution is conditionally applying solution of #1689 when root-less

[neelasha-09]

@FxKu @CyberDem0n @Jan-M @sdudoladov : Could you please review the PR ?

[neelasha-09]

@FxKu : Could you please review and update ?

[FxKu]

@neelasha-09 well you addressed one comment. What about the other? There's some redundant code where only the command
"/bin/bash" vs. "/bin/su" differ. It can be simplified.

[neelasha-09]

@FxKu
execCommand has different number of args in each case
so we cannot simply have a string with 2 values, it's two different execCommands.
We agree with modifying the code if that is requried.

[FxKu]

indeed, then still move all the redundant parts out of the if else block.

[neelasha-09]

@FxKu Can you please suggest how can it be done ?

[neelasha-09]

@FxKu : Please check and approve the PR

[FxKu]

@neelasha-09 please fix the errors (e.g. define result variable etc.) so that unit tests will run.

[neelasha-09]

@FxKu the command at line 120 was added to define the variable as I'm not sure of the type of the variables to be defined for result and err
result, err := c.ExecCommand(podName, "/bin/bash")
Please confirm the same

[FxKu]

You will know it if you check what ExecCommand function returns? Since err is already defined above is enough to just define var result string

[FxKu]

Only minor issues left. Please remove some unnecessary extra lines that you have introduced. Another event can be changed to warning. Please, make sure go.fmt has been run across your code.

[CyberDem0n]

👍

[FxKu]

👍

[FxKu]

Thanks @neelasha-09 for your contribution!