Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

major version upgrade for rootless and ocp : solving #1689 #1770

Merged
merged 9 commits into from
Mar 31, 2022
Merged

major version upgrade for rootless and ocp : solving #1689 #1770

Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
43ed7fb
Update majorversionupgrade.go
neelasha-09 Feb 3, 2022
633bb0d
Update majorversionupgrade.go
neelasha-09 Feb 15, 2022
a3569fb
Update majorversionupgrade.go
neelasha-09 Feb 16, 2022
17ee075
Update majorversionupgrade.go
neelasha-09 Mar 24, 2022
636f3ca
Update majorversionupgrade.go
neelasha-09 Mar 25, 2022
59f6d1a
Update majorversionupgrade.go
neelasha-09 Mar 30, 2022
e4c7775
Update majorversionupgrade.go
neelasha-09 Mar 30, 2022
e62d46b
Update majorversionupgrade.go
neelasha-09 Mar 31, 2022
21c336e
Update pkg/cluster/majorversionupgrade.go
FxKu Mar 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions pkg/cluster/majorversionupgrade.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package cluster

import (
"fmt"
"strings"

"github.com/zalando/postgres-operator/pkg/spec"
"github.com/zalando/postgres-operator/pkg/util"
Expand Down Expand Up @@ -106,15 +107,31 @@ func (c *Cluster) majorVersionUpgrade() error {
c.eventRecorder.Eventf(c.GetReference(), v1.EventTypeNormal, "Major Version Upgrade", "Starting major version upgrade on pod %s of %d pods", masterPod.Name, numberOfPods)
upgradeCommand := fmt.Sprintf("/usr/bin/python3 /scripts/inplace_upgrade.py %d 2>&1 | tee last_upgrade.log", numberOfPods)

result, err := c.ExecCommand(podName, "/bin/su", "postgres", "-c", upgradeCommand)

neelasha-09 marked this conversation as resolved.
Show resolved Hide resolved
c.logger.Debugf("checking if the spilo image runs with root or non-root (check for user id=0)")
resultIdCheck, errIdCheck := c.ExecCommand(podName, "/bin/bash", "-c", "/usr/bin/id -u")
if errIdCheck != nil {
c.eventRecorder.Eventf(c.GetReference(), v1.EventTypeWarning, "Major Version Upgrade", "Checking user id to run upgrade from %d to %d FAILED: %v", c.currentMajorVersion, desiredVersion, errIdCheck)
}

resultIdCheck = strings.TrimSuffix(resultIdCheck, "\n")
var result string
FxKu marked this conversation as resolved.
Show resolved Hide resolved
if resultIdCheck != "0" {
FxKu marked this conversation as resolved.
Show resolved Hide resolved
c.logger.Infof("User id was identified as: %s, hence default user is non-root already", resultIdCheck)
result, err = c.ExecCommand(podName, "/bin/bash", "-c", upgradeCommand)
} else {
c.logger.Infof("User id was identified as: %s, using su to reach the postgres user", resultIdCheck)
result, err = c.ExecCommand(podName, "/bin/su", "postgres", "-c", upgradeCommand)
}
if err != nil {
c.eventRecorder.Eventf(c.GetReference(), v1.EventTypeNormal, "Major Version Upgrade", "Upgrade from %d to %d FAILED: %v", c.currentMajorVersion, desiredVersion, err)
neelasha-09 marked this conversation as resolved.
Show resolved Hide resolved
return err
}

c.logger.Infof("upgrade action triggered and command completed: %s", result[:100])

c.eventRecorder.Eventf(c.GetReference(), v1.EventTypeNormal, "Major Version Upgrade", "Upgrade from %d to %d finished", c.currentMajorVersion, desiredVersion)
}

neelasha-09 marked this conversation as resolved.
Show resolved Hide resolved
}

return nil
Expand Down