Feature/validate role options #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only accept CREATE ROLE flags that doesn't have any params (i.e. not ADMIN or CONNECTION LIMIT). Check that both flag and NOflag are not used at the same time.
mkabilov
reviewed
Sep 15, 2017
pkg/cluster/util.go
Outdated
| func invertFlag(flag string) string { | ||
| if flag[:2] == "NO" { | ||
| return flag[2:] | ||
| } else { |
mkabilov
reviewed
Sep 15, 2017
pkg/cluster/util.go
Outdated
| return "NO" + flag | ||
| } | ||
| } | ||
|
|
||
| func normalizeUserFlags(userFlags []string) (flags []string, err error) { |
There was a problem hiding this comment.
I think in this case there is no strong need for the named return values.
Besides, code like return nil, fmt.Errorf("bla") as for me looks more clear than
err = fmt.Errorf("bla")
return
|
👍 |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only accept CREATE ROLE flags that doesn't have any params (i.e.
not ADMIN or CONNECTION LIMIT). Check that both flag and NOflag
are not used at the same time.