Support inherited annotations for all major objects #1236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FxKu
requested review from
avaczi,
CyberDem0n,
erthalion,
Jan-M,
RafiaSabih and
sdudoladov
as code owners
FxKu
force-pushed
the
inherited-annotations
branch
from
501ef10
to
c4b1d69
Compare
Jan-M
changed the title
RafiaSabih
reviewed
Dec 10, 2020
RafiaSabih
reviewed
Dec 10, 2020
RafiaSabih
reviewed
Dec 10, 2020
|
|
||
| return nil | ||
| } | ||
|
|
There was a problem hiding this comment.
Not sure if returning nil is used anywhere, can simply return annotations.
There was a problem hiding this comment.
it should return nil if there are no Annotations defined in the config and on the resource. For example TestGeneratePodDisruptionBudget fails for me if I return an empty map as this test does not define any Annotations at all. I have also added this behavior to the AnnotationsToPropagate function, too.
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for an inherited annotations feature, similar to inherited labels, to estimate how much it would take.