add default values to operatorconfiguration crd #1283
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since v1 and K8s 1.17 allows defining defaults in the CRD schema validation. With this we could at some point get gid of all the coalescing in operator_config.go.
For compatibility with older K8s versions a coalesce function for
int64
is added. The go code for the CRD validation does not use defaults at the moment because values have to be defined as*JSON
(which looks like too much work right now - and maybe we drop this code at some point anyway to only rely on manifests).This PR incl. a few more minor changes:
logical_backup_job_prefix
to CRD validation and all examplesv1.6.0
tag to every mention of the logical backup imagemaster-12
tag to default pooler imageconnection_pooler_number_of_instances
to 1addresses #1277