add a prefix for the name of a logical backup job #1287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdudoladov
requested review from
avaczi,
CyberDem0n,
erthalion,
Jan-M and
RafiaSabih
as code owners
FxKu
reviewed
Jan 6, 2021
Jan-M
reviewed
Jan 6, 2021
|
Docker image "registry-write.opensource.zalan.do/acid/postgres-operator-ui-test:v1.6.0-5-g7e4170a-pr-1287-2" is not based on an approved base image. Currently, this will have no impact on your deployments, but builds using non-allowed images will be blocked from deployment from February 1st 2021. To create a compliant Docker image of your application, you must reference an allowed Docker image as its base image in your Dockerfile. This base image must come from the Open Source Registry namespace |
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Operator currently prepends the
logical-backup-prefix to the name of a CronJob doing the backup.The prefix proved to be too long as it counts towards the name length limit imposed by k8s.
This patch makes the prefix configurable.
Automatic job renaming after prefix change is out of scope. Operator will automatically create a new job with the updated prefix. The old job will stay around and has to be deleted manually. Logical backup jobs for
$CLUSTERNAMEare visible withkubectl get cronjobs -l application=spilo,cluster-name=$CLUSTERNAMEOperator currently does not assign any specific labels to the jobs.