making pgTeamMap a pointer #1349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FxKu
requested review from
avaczi,
CyberDem0n,
erthalion,
Jan-M,
RafiaSabih and
sdudoladov
as code owners
Jan-M
reviewed
Feb 10, 2021
| @@ -49,7 +49,7 @@ var ( | |||
| type Config struct { | |||
| OpConfig config.Config | |||
| RestConfig *rest.Config | |||
| PgTeamMap pgteams.PostgresTeamMap | |||
| PgTeamMap *pgteams.PostgresTeamMap | |||
There was a problem hiding this comment.
did we not say that we could just not use this var at all and always just use
cluster: c.opconfig.pgteams?
|
👍 |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when a PostgresTeam map is updated with more teams/users, it's immediately reflected in the controller's pgTeamMap (can be seen from logs). However,
initUsersfunction do not seem to pick them up. Only after the operator is restarted, it seems to work.Essential change 1: Make cluster's PgTeamMap a pointer:
Essential change 2: Additional teams and members are only fetched if the feature is enabled and the PgTeamMap is not
nil