Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix operator configs runasuser and runasgroup #1361

Merged
merged 1 commit into from
Feb 12, 2021

Conversation

tommasopozzetti
Copy link
Contributor

@tommasopozzetti tommasopozzetti commented Feb 11, 2021

This commit fixes a typo in the operator's configuration that would lead to the configs spilo_runasuser and spilo_runasgroup to be ignored.

fixes #1359

This commit fixes a typo in the operator's configuration
that would lead to the configs spilo_runasuser and
spilo_runasgroup to be ignored.
@FxKu
Copy link
Member

FxKu commented Feb 12, 2021

👍

1 similar comment
@Jan-M
Copy link
Member

Jan-M commented Feb 12, 2021

👍

@FxKu FxKu merged commit c1c0d5f into zalando:master Feb 12, 2021
@FxKu
Copy link
Member

FxKu commented Feb 12, 2021

Thanks @tommasopozzetti for your contribution 👍

@FxKu FxKu added this to the 1.7 milestone Feb 12, 2021
@caiconkhicon
Copy link
Contributor

caiconkhicon commented Feb 23, 2021

@FxKu : sorry I know this commit had been merged and added to v1.6.1, but has anyone tested it yet? I tried with v1.6.1 and runasuser and runasgroup were still ignored.

Update: If I use ConfigMap configuration (helm install postgres-operator ./charts/postgres-operator) it does not work, but if I use the CRD configuration (helm install postgres-operator ./charts/postgres-operator -f ./charts/postgres-operator/values-crd.yaml) it works

@cortopy
Copy link

cortopy commented May 25, 2021

Same here with 1.6.2

@FxKu
Copy link
Member

FxKu commented May 28, 2021

Thanks @caiconkhicon and @cortopy for bringing it up again. The omitempty is indeed wrong there and leads to the error. I'll fix it in #1503

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Operator runasuser/runasgroup configs not working
5 participants