Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve inherited annotations #2657

Merged
merged 11 commits into from
Jun 26, 2024
Merged

Improve inherited annotations #2657

merged 11 commits into from
Jun 26, 2024

Conversation

hughcapet
Copy link
Member

@hughcapet hughcapet commented Jun 10, 2024 •
edited by FxKu
Loading

  • Annotate PVC on Sync/Update, not only change PVC template
  • Don't rotate pods when only annotations changed
  • Annotate Logical Backup's and Pooler's pods
  • Annotate PDB, Endpoints created by the Operator, Secrets, Logical Backup jobs

Inherited annotations are only added/updated, not removed

addresses #2642

@FxKu FxKu modified the milestone: 1.13.0 Jun 10, 2024
@hughcapet hughcapet marked this pull request as ready for review June 10, 2024 19:04
FxKu
FxKu reviewed Jun 12, 2024
View reviewed changes
pkg/cluster/cluster.go Outdated Show resolved Hide resolved
FxKu
FxKu reviewed Jun 12, 2024
View reviewed changes
pkg/cluster/cluster.go Outdated Show resolved Hide resolved
@hughcapet @FxKu
Apply suggestions from code review
7d43a97 
Co-authored-by: Felix Kunde <felix-kunde@gmx.de>
@hughcapet hughcapet marked this pull request as draft June 13, 2024 05:43
@hughcapet hughcapet marked this pull request as ready for review June 13, 2024 20:26
FxKu
FxKu reviewed Jun 14, 2024
View reviewed changes
e2e/tests/test_e2e.py Outdated Show resolved Hide resolved
FxKu
FxKu reviewed Jun 14, 2024
View reviewed changes
pkg/cluster/sync.go Outdated Show resolved Hide resolved
FxKu
FxKu reviewed Jun 14, 2024
View reviewed changes
pkg/cluster/volumes.go Outdated Show resolved Hide resolved
FxKu
FxKu reviewed Jun 14, 2024
View reviewed changes
pkg/cluster/volumes.go Outdated Show resolved Hide resolved
@hughcapet hughcapet requested review from FxKu and removed request for Jan-M June 17, 2024 08:06
idanovinda
idanovinda approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@idanovinda idanovinda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, had a few questions and confirmed them with Polina 👍

FxKu
FxKu reviewed Jun 25, 2024
View reviewed changes
pkg/cluster/volumes.go Outdated Show resolved Hide resolved
@hughcapet @FxKu
Update pkg/cluster/volumes.go
874ee59 
Co-authored-by: Felix Kunde <felix-kunde@gmx.de>
@hughcapet hughcapet requested a review from FxKu June 26, 2024 07:25
@FxKu
Copy link
Member

FxKu commented Jun 26, 2024

👍

1 similar comment
@hughcapet
Copy link
Member Author

👍

@hughcapet hughcapet merged commit 47efca3 into master Jun 26, 2024
9 checks passed
@hughcapet hughcapet deleted the fix/inherited_annotations branch June 26, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FxKu FxKu FxKu approved these changes

@idanovinda idanovinda idanovinda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Postgres Operator
Status: Done
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hughcapet @FxKu @idanovinda