-
Notifications
You must be signed in to change notification settings - Fork 944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document taint-based eviction #468
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some typos
docs/administrator.md
Outdated
@@ -146,6 +146,11 @@ data: | |||
... | |||
``` | |||
|
|||
Note that the Kubernetes version 1.13 brings [taint-based eviction](https://kubernetes.io/docs/concepts/configuration/taint-and-toleration/#taint-based-evictions) to the beta stage and enables it by default. | |||
Postgres pods by default receive tolerations for `unreachable` and `noExecute` taints with the timeout of `5m`. | |||
Depending on you setup, you may want to adjust these parameters to prevent master pods from being evicted by Kubernetes runtime. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
your setup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
by the Kubernetes runtime
docs/administrator.md
Outdated
Note that the Kubernetes version 1.13 brings [taint-based eviction](https://kubernetes.io/docs/concepts/configuration/taint-and-toleration/#taint-based-evictions) to the beta stage and enables it by default. | ||
Postgres pods by default receive tolerations for `unreachable` and `noExecute` taints with the timeout of `5m`. | ||
Depending on you setup, you may want to adjust these parameters to prevent master pods from being evicted by Kubernetes runtime. | ||
To prevent eviction completely, specify the toleration without specifying the `tolerationSeconds` value (similar to how Kubernetes own DaemonSets are configured) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
specify the toleration by leaving out the ...
Kubernetes' own ...
Address review comments
@FxKu I updated the PR. Thanks for the review ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
based on #465