Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document taint-based eviction #468

Merged
merged 3 commits into from
Feb 20, 2019
Merged

Document taint-based eviction #468

merged 3 commits into from
Feb 20, 2019

Conversation

sdudoladov
Copy link
Member

based on #465

@coveralls
Copy link

Coverage Status

Coverage remained the same at 23.705% when pulling 7917ee2 on improve-tolerations-doc into 4489593 on master.

Copy link
Member

@FxKu FxKu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some typos

@@ -146,6 +146,11 @@ data:
...
```

Note that the Kubernetes version 1.13 brings [taint-based eviction](https://kubernetes.io/docs/concepts/configuration/taint-and-toleration/#taint-based-evictions) to the beta stage and enables it by default.
Postgres pods by default receive tolerations for `unreachable` and `noExecute` taints with the timeout of `5m`.
Depending on you setup, you may want to adjust these parameters to prevent master pods from being evicted by Kubernetes runtime.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your setup

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by the Kubernetes runtime

Note that the Kubernetes version 1.13 brings [taint-based eviction](https://kubernetes.io/docs/concepts/configuration/taint-and-toleration/#taint-based-evictions) to the beta stage and enables it by default.
Postgres pods by default receive tolerations for `unreachable` and `noExecute` taints with the timeout of `5m`.
Depending on you setup, you may want to adjust these parameters to prevent master pods from being evicted by Kubernetes runtime.
To prevent eviction completely, specify the toleration without specifying the `tolerationSeconds` value (similar to how Kubernetes own DaemonSets are configured)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

specify the toleration by leaving out the ...

Kubernetes' own ...

Address review comments
@sdudoladov
Copy link
Member Author

@FxKu I updated the PR. Thanks for the review !

Copy link
Member

@FxKu FxKu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sdudoladov sdudoladov merged commit 2e9b653 into master Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants