omit PgVersion diff on sync #860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FxKu
requested review from
avaczi,
CyberDem0n,
erthalion,
Jan-M,
RafiaSabih and
sdudoladov
as code owners
FxKu
force-pushed
the
version-change-error
branch
from
5e486b7
to
9668d27
Compare
FxKu
commented
Mar 10, 2020
erthalion
reviewed
Mar 11, 2020
| @@ -716,6 +716,55 @@ func makeResources(cpuRequest, memoryRequest, cpuLimit, memoryLimit string) acid | |||
| } | |||
| } | |||
|
|
|||
| func extractPgVersionFromBinPath(binPath string, template string) (string, error) { | |||
| var pgVersion float32 | |||
There was a problem hiding this comment.
Shouldn't it be just an integer?
There was a problem hiding this comment.
Yeah, forgot that for a couple of years it still would be a thing.
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the Postgres version can currently break the cluster. It is caught on
Updatebut not onSync.Retrieving the current PG version on sync is only possible through the
bin_dirsetting in theSPILO_CONFIGURATIONenv variable of thepostgrescontainer. Extracting the version is done withSscanfto make it work even when the bin path template is configurable, as suggested in #554.This PR also adds
PostgresParamwherePgVersionfield is read