Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move operator to go 1.14 #882

Merged
merged 4 commits into from Mar 30, 2020
Merged

Move operator to go 1.14 #882

merged 4 commits into from Mar 30, 2020

Conversation

FxKu
Copy link
Member

@FxKu FxKu commented Mar 27, 2020

haven't been updated for a while now

@FxKu FxKu added this to the 1.5 milestone Mar 27, 2020
@sdudoladov
Copy link
Member

actually one already sees from the build pipeline that it does not help

@FxKu
Copy link
Member Author

FxKu commented Mar 27, 2020

/root/go/pkg/mod/k8s.io/apimachinery@v0.18.0/pkg/util/errors/errors.go:99:10: undefined: errors.Is
note: module requires Go 1.13

got this error also locally

@sdudoladov sdudoladov changed the title update go modules march 2020 Move operator to go 1.14 Mar 27, 2020
@sdudoladov
Copy link
Member

@sdudoladov
Copy link
Member

I have looked into this Context change. It provides the foundation to future k8s features (distributed tracing of API calls / request cancellation) and removes some API inconsistencies. I think for now we do not need to explicitly manipulate contexts, so using an empty context context.TODO() is fine

Summary from k8s 1.18 changelog:

Signatures on methods in generated clientsets, dynamic, metadata, and scale clients have been 
modified to accept context.Context as a first argument. 

Signatures of Create, Update, and Patch  methods have been updated to accept CreateOptions, UpdateOptions and PatchOptions respectively. 

Signatures of Delete and DeleteCollection methods now accept DeleteOptions by value instead of by reference. 

Generated clientsets with the previous interface have been added in new "deprecated" packages to allow incremental migration to the new APIs. 
The deprecated packages will be removed in the 1.21 release. A tool is available at http://sigs.k8s.io/clientgofix to rewrite
method invocations to the new signatures.

@FxKu
Copy link
Member Author

FxKu commented Mar 30, 2020

👍

1 similar comment
@sdudoladov
Copy link
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants