Prevent superuser from being a connection pool user #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erthalion
requested review from
avaczi,
CyberDem0n,
FxKu,
Jan-M,
RafiaSabih and
sdudoladov
as code owners
erthalion
changed the title
erthalion
force-pushed
the
fix/pooler-not-superuser
branch
from
4079115
to
6ff099e
Compare
It's not supported, neither it's a best practice. Also fix potential null pointer access.
FxKu
reviewed
Apr 7, 2020
Comment on lines
+172
to
+175
| if result.ConnectionPooler.User == result.SuperUsername { | ||
| msg := "Connection pool user is not allowed to be the same as super user, username: %s" | ||
| panic(fmt.Errorf(msg, result.ConnectionPooler.User)) | ||
| } |
There was a problem hiding this comment.
isn't it validated in config.go anyway?
|
👍 |
sdudoladov
reviewed
Apr 8, 2020
For protected users it makes sense by intent of protecting this users (e.g. from being overriden or used as something else than supposed). For system users the reason is the same as for superuser, it's about replicastion user and it's under patroni control.
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not supported, neither it's a best practice. Also fix potential
null pointer access.