when kubernetes_use_configmaps -> skip further endpoints actions even delete #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReSearchITEng
requested review from
avaczi,
CyberDem0n,
erthalion,
FxKu,
Jan-M,
RafiaSabih and
sdudoladov
as code owners
FxKu
reviewed
Apr 16, 2020
FxKu
reviewed
Apr 16, 2020
thanks! Co-Authored-By: Felix Kunde <felix-kunde@gmx.de>
Co-Authored-By: Felix Kunde <felix-kunde@gmx.de>
FxKu
reviewed
Apr 16, 2020
|
👍 |
1 similar comment
|
👍 |
|
@ReSearchITEng thanks for yet another contribution 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
code was still trying to remove endpoints even when kubernetes_use_configmaps was true (continuation of #887)
It is desired to inhibit the delete as well, as there might be no perms to make any actions against them, so, to be on the safe side, we are inhibiting this delete when it is not required.