Propagate annotations to the StatefulSet #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RafiaSabih
requested review from
avaczi,
CyberDem0n,
erthalion,
FxKu,
Jan-M and
sdudoladov
as code owners
|
- set the type of the new configuration parameter to be array of strings - propagate the annotations to statefulset at sync
Jan-M
reviewed
Apr 27, 2020
|
Jan-M
reviewed
Apr 27, 2020
Jan-M
reviewed
Apr 27, 2020
added 2 commits
April 28, 2020 11:46
-handle rollingUpdate flag -modularize code -rename config parameter name
Jan-M
reviewed
Apr 28, 2020
sdudoladov
reviewed
Apr 30, 2020
|
|
||
| k8s.delete_operator_pod() | ||
|
|
||
| annotations = { |
There was a problem hiding this comment.
is it meant to be pg_crd_annotations["metadata"]["annotations"] ?
| return False | ||
| for key in svc.metadata.annotations: | ||
| if svc.metadata.annotations[key] != annotations[key]: | ||
| return False | ||
| return True | ||
|
|
||
| def check_statefulset_annotations(self, sset_labels, annotations, namespace='default'): | ||
| ssets = self.api.apps_v1.list_namespaced_stateful_set(namespace, label_selector=sset_labels, limit=1).items | ||
| for sset in ssets: |
There was a problem hiding this comment.
Why loop if only one stateful set is fetched ?
It is effectively sset = self.api.apps_v1.list_namespaced_stateful_set(namespace, label_selector=sset_labels, limit=1).items[0]
sdudoladov
reviewed
Apr 30, 2020
sdudoladov
reviewed
Apr 30, 2020
- handle the update path to update sts and connection pooler deployment. This way no need to wait for sync - rename the parameter to downscaler_annotations - handle other review comments
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help with this reported issue.