fix typo in additionalVolume struct #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siku4
requested review from
avaczi,
CyberDem0n,
erthalion,
FxKu,
Jan-M,
RafiaSabih and
sdudoladov
as code owners
|
Ah, good catch. Unfortunately, I can see that the multi_namespace tests is failing, which uses the complete manifest. Probably because the mentioned configmap and PVC do not exists. @siku4 can you comment out the first two examples for additionalVolumes? And then maybe move the emptyDir volume to the top. I think that one should work. |
siku4
force-pushed
the
fix-typo-in-additionalVolume-struct
branch
2 times, most recently
from
c776c94
to
94da000
Compare
siku4
force-pushed
the
fix-typo-in-additionalVolume-struct
branch
from
94da000
to
29acb67
Compare
|
👍 |
|
👍 |
|
@siku4 welcome to our community and thanks for the contribution ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to PR #736:
It is not possible to specify a
volumeSourcebased on the given cluster manifests examples and the documentation: The name of the json field within theAdditionalVolumestruct isvolume. The name specified in the CRD isvolumeSource:postgres-operator/manifests/postgresql.crd.yaml
Lines 45 to 48 in 3c91bde