Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#426 module-info.java is placed in the wrong jar #483

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

viktor44
Copy link

@viktor44 viktor44 commented Aug 4, 2023

Description

Fixes #426

File module-info.class was moved from META-INF/versions/9 to the root folder of the jar.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@MALPI
Copy link
Member

MALPI commented Sep 2, 2023

I will take a look in the next days.

@MALPI MALPI self-assigned this Sep 2, 2023
@viktor44
Copy link
Author

Up! 😄

@otrosien
Copy link
Member

@viktor44 hey there, sorry for the long silence. The PR looks good, but I do have some questions.

mvn install -Dmaven.test.skip=true

Running this locally, adds the module-info.class to META-INF/versions/9/module-info.class. Maybe we somehow missed publishing this properly in the previous releases. Reading moditect README, setting jvmVersion to 9 or higher increases the compatiblity with old jar-scanning tools (which by now is an obsolete argument, I guess)

Secondly, let's upgrade the maven plugin to the current stable version.

And finally, please sign-off your commit, using git commit --amend --signoff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

module-info.java is placed in the wrong jar
3 participants