Reuse spring classloader for failsafe scheduler threads #1252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buzzlighty
requested review from
whiskeysierra,
lukasniemeier-zalando,
AlexanderYastrebov and
fatroom
as code owners
buzzlighty
force-pushed
the
bugfix/jaxb-classloader
branch
2 times, most recently
from
49c9b26
to
1e07d84
Compare
buzzlighty
force-pushed
the
bugfix/jaxb-classloader
branch
from
1e07d84
to
d21bb1c
Compare
|
@buzzlighty can you please rebase on master to get the build passing? |
|
@fatroom sure, can you have another look please? |
|
@buzzlighty will do today |
|
👍 |
|
Thank you for your contribution, included in release 3.2.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #953
Description
Fix
PreserveContextClassLoaderTaskDecoratorin order to set a class loader from invoking thread to a runner thread.Motivation and Context
Previously this task decorator has been created to resolve above mentioned issue. However there's a bug in this task decorator which prevents it from working as expected. The code in labmda should assign class loader to runner thread but it was assigning it to invoking thread, which does not make sense as it's the same thread which the class loader is being obtained from.
Types of changes
Checklist: