Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jakartaee-api in favor of jakarta.xml.bind-api #1476

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

msdousti
Copy link
Contributor

We only need to import jakarta.xml.bind-api rather than the full-blown jakartaee-api, which is only used in riptide-core tests.

This also addresses #1475.

Description

Replaced test dependency jakarta.platform:jakartaee-api with jakarta.xml.bind:jakarta.xml.bind-api.

Motivation and Context

Addresses #1475.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

We only need to import jakarta.xml.bind-api rather than the full-blown jakartaee-api.
@Semernitskaya
Copy link
Contributor

👍

@fatroom
Copy link
Member

fatroom commented Jun 26, 2023

Thank you for the contribution!

@fatroom fatroom merged commit b0a12df into zalando:main Jun 26, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants