-
Notifications
You must be signed in to change notification settings - Fork 350
/
ingressv1beta1.go
434 lines (394 loc) · 13.1 KB
/
ingressv1beta1.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
package kubernetes
import (
"errors"
"fmt"
"regexp"
"strings"
log "github.com/sirupsen/logrus"
"github.com/zalando/skipper/dataclients/kubernetes/definitions"
"github.com/zalando/skipper/eskip"
)
func setPath(m PathMode, r *eskip.Route, p string) {
if p == "" {
return
}
switch m {
case PathPrefix:
r.Predicates = append(r.Predicates, &eskip.Predicate{
Name: "PathSubtree",
Args: []interface{}{p},
})
case PathRegexp:
r.PathRegexps = []string{p}
default:
if p == "/" {
r.PathRegexps = []string{"^/"}
} else {
r.PathRegexps = []string{"^(" + p + ")"}
}
}
}
func convertPathRule(
state *clusterState,
metadata *definitions.Metadata,
host string,
prule *definitions.PathRule,
pathMode PathMode,
allowedExternalNames []*regexp.Regexp,
) (*eskip.Route, error) {
ns := metadata.Namespace
name := metadata.Name
if prule.Backend == nil {
return nil, fmt.Errorf("invalid path rule, missing backend in: %s/%s/%s", ns, name, host)
}
var (
eps []string
err error
svc *service
)
var hostRegexp []string
if host != "" {
hostRegexp = []string{createHostRx(host)}
}
svcPort := prule.Backend.ServicePort
svcName := prule.Backend.ServiceName
svc, err = state.getService(ns, svcName)
if err != nil {
log.Errorf("convertPathRule: Failed to get service %s, %s, %s", ns, svcName, svcPort)
return nil, err
}
servicePort, err := svc.getServicePort(svcPort)
if err != nil {
// service definition is wrong or no pods
err = nil
if len(eps) > 0 {
// should never happen
log.Errorf("convertPathRule: Failed to find target port for service %s, but %d endpoints exist. Kubernetes has inconsistent data", svcName, len(eps))
}
} else if svc.Spec.Type == "ExternalName" {
return externalNameRoute(ns, name, host, hostRegexp, svc, servicePort, allowedExternalNames)
} else {
protocol := "http"
if p, ok := metadata.Annotations[skipperBackendProtocolAnnotationKey]; ok {
protocol = p
}
eps = state.getEndpointsByService(ns, svcName, protocol, servicePort)
log.Debugf("convertPathRule: Found %d endpoints %s for %s", len(eps), servicePort, svcName)
}
if len(eps) == 0 {
// add shunt route https://github.com/zalando/skipper/issues/1525
log.Debugf("convertPathRule: add shuntroute to return 502 for ingress %s/%s service %s with %d endpoints", ns, name, svcName, len(eps))
r := &eskip.Route{
Id: routeID(ns, name, host, prule.Path, svcName),
HostRegexps: hostRegexp,
}
setPath(pathMode, r, prule.Path)
setTraffic(r, svcName, prule.Backend.Traffic, prule.Backend.NoopCount)
shuntRoute(r)
return r, nil
}
log.Debugf("convertPathRule: %d routes for %s/%s/%s", len(eps), ns, svcName, svcPort)
if len(eps) == 1 {
r := &eskip.Route{
Id: routeID(ns, name, host, prule.Path, svcName),
Backend: eps[0],
BackendType: eskip.NetworkBackend,
HostRegexps: hostRegexp,
}
setPath(pathMode, r, prule.Path)
setTraffic(r, svcName, prule.Backend.Traffic, prule.Backend.NoopCount)
return r, nil
}
r := &eskip.Route{
Id: routeID(ns, name, host, prule.Path, svcName),
BackendType: eskip.LBBackend,
LBEndpoints: eps,
LBAlgorithm: getLoadBalancerAlgorithm(metadata),
HostRegexps: hostRegexp,
}
setPath(pathMode, r, prule.Path)
setTraffic(r, svcName, prule.Backend.Traffic, prule.Backend.NoopCount)
return r, nil
}
func (ing *ingress) addEndpointsRule(ic ingressContext, host string, prule *definitions.PathRule) error {
meta := ic.ingress.Metadata
endpointsRoute, err := convertPathRule(
ic.state,
meta,
host,
prule,
ic.pathMode,
ing.allowedExternalNames,
)
if err != nil {
// if the service is not found the route should be removed
if err == errServiceNotFound || err == errResourceNotFound {
return nil
}
// TODO: this error checking should not really be used, and the error handling of the ingress
// problems should be refactored such that a single ingress's error doesn't block the
// processing of the independent ingresses.
if errors.Is(err, errNotAllowedExternalName) {
log.Infof("Not allowed external name: %v", err)
return nil
}
// Ingress status field does not support errors
return fmt.Errorf("error while getting service: %v", err)
}
// safe prepend, see: https://play.golang.org/p/zg5aGKJpRyK
filters := make([]*eskip.Filter, len(endpointsRoute.Filters)+len(ic.annotationFilters))
copy(filters, ic.annotationFilters)
copy(filters[len(ic.annotationFilters):], endpointsRoute.Filters)
endpointsRoute.Filters = filters
// add pre-configured default filters
df, err := ic.defaultFilters.getNamed(meta.Namespace, prule.Backend.ServiceName)
if err != nil {
ic.logger.Errorf("Failed to retrieve default filters: %v.", err)
} else {
// it's safe to prepend, because type defaultFilters copies the slice during get()
endpointsRoute.Filters = append(df, endpointsRoute.Filters...)
}
err = applyAnnotationPredicates(ic.pathMode, endpointsRoute, ic.annotationPredicate)
if err != nil {
ic.logger.Errorf("failed to apply annotation predicates: %v", err)
}
ic.addHostRoute(host, endpointsRoute)
redirect := ic.redirect
ewRangeMatch := false
for _, s := range ing.eastWestRangeDomains {
if strings.HasSuffix(host, s) {
ewRangeMatch = true
break
}
}
if !(ewRangeMatch || strings.HasSuffix(host, ing.kubernetesEastWestDomain) && ing.kubernetesEastWestDomain != "") {
switch {
case redirect.ignore:
// no redirect
case redirect.enable:
ic.addHostRoute(host, createIngressEnableHTTPSRedirect(endpointsRoute, redirect.code))
redirect.setHost(host)
case redirect.disable:
ic.addHostRoute(host, createIngressDisableHTTPSRedirect(endpointsRoute))
redirect.setHostDisabled(host)
case redirect.defaultEnabled:
ic.addHostRoute(host, createIngressEnableHTTPSRedirect(endpointsRoute, redirect.code))
redirect.setHost(host)
}
}
if ing.kubernetesEnableEastWest {
ewRoute := createEastWestRouteIng(ing.kubernetesEastWestDomain, meta.Name, meta.Namespace, endpointsRoute)
ewHost := fmt.Sprintf("%s.%s.%s", meta.Name, meta.Namespace, ing.kubernetesEastWestDomain)
ic.addHostRoute(ewHost, ewRoute)
}
return nil
}
// computeBackendWeights computes and sets the backend traffic weights on the
// rule backends.
// The traffic is calculated based on the following rules:
//
// * if no weight is defined for a backend it will get weight 0.
// * if no weights are specified for all backends of a path, then traffic will
// be distributed equally.
//
// Each traffic weight is relative to the number of backends per path. If there
// are multiple backends per path the weight will be relative to the number of
// remaining backends for the path e.g. if the weight is specified as
//
// backend-1: 0.2
// backend-2: 0.6
// backend-3: 0.2
//
// then the weight will be calculated to:
//
// backend-1: 0.2
// backend-2: 0.75
// backend-3: 1.0
//
// where for a weight of 1.0 no Traffic predicate will be generated.
func computeBackendWeights(backendWeights map[string]float64, rule *definitions.Rule) {
type pathInfo struct {
sum float64
lastActive *definitions.Backend
count int
weightsCount int
}
// get backend weight sum and count of backends for all paths
pathInfos := make(map[string]*pathInfo)
for _, path := range rule.Http.Paths {
sc, ok := pathInfos[path.Path]
if !ok {
sc = &pathInfo{}
pathInfos[path.Path] = sc
}
if weight, ok := backendWeights[path.Backend.ServiceName]; ok {
sc.sum += weight
if weight > 0 {
sc.lastActive = path.Backend
sc.weightsCount++
}
} else {
sc.count++
}
}
// calculate traffic weight for each backend
for _, path := range rule.Http.Paths {
if sc, ok := pathInfos[path.Path]; ok {
if weight, ok := backendWeights[path.Backend.ServiceName]; ok {
// force a weight of 1.0 for the last backend with a non-zero weight to avoid rounding issues
if sc.lastActive == path.Backend {
path.Backend.Traffic = 1.0
continue
}
path.Backend.Traffic = weight / sc.sum
// subtract weight from the sum in order to
// give subsequent backends a higher relative
// weight.
sc.sum -= weight
// noops are required to make sure that routes are in order selected by
// routing tree
if sc.weightsCount > 2 {
path.Backend.NoopCount = sc.weightsCount - 2
}
sc.weightsCount--
} else if sc.sum == 0 && sc.count > 0 {
path.Backend.Traffic = 1.0 / float64(sc.count)
}
// reduce count by one in order to give subsequent
// backends for the path a higher relative weight.
sc.count--
}
}
}
// TODO: default filters not applied to 'extra' routes from the custom route annotations. Is it on purpose?
// https://github.com/zalando/skipper/issues/1287
func (ing *ingress) addSpecRule(ic ingressContext, ru *definitions.Rule) error {
if ru.Http == nil {
ic.logger.Warn("invalid ingress item: rule missing http definitions")
return nil
}
// update Traffic field for each backend
computeBackendWeights(ic.backendWeights, ru)
for _, prule := range ru.Http.Paths {
addExtraRoutes(ic, ru.Host, prule.Path, "ImplementationSpecific", ing.kubernetesEastWestDomain, ing.kubernetesEnableEastWest)
if prule.Backend.Traffic > 0 {
err := ing.addEndpointsRule(ic, ru.Host, prule)
if err != nil {
return err
}
}
}
return nil
}
// converts the default backend if any
func (ing *ingress) convertDefaultBackend(
state *clusterState,
i *definitions.IngressItem,
) (*eskip.Route, bool, error) {
// the usage of the default backend depends on what we want
// we can generate a hostname out of it based on shared rules
// and instructions in annotations, if there are no rules defined
// this is a flaw in the ingress API design, because it is not on the hosts' level, but the spec
// tells to match if no rule matches. This means that there is no matching rule on this ingress
// and if there are multiple ingress items, then there is a race between them.
if i.Spec.DefaultBackend == nil {
return nil, false, nil
}
var (
eps []string
err error
ns = i.Metadata.Namespace
name = i.Metadata.Name
svcName = i.Spec.DefaultBackend.ServiceName
svcPort = i.Spec.DefaultBackend.ServicePort
)
svc, err := state.getService(ns, svcName)
if err != nil {
log.Errorf("convertDefaultBackend: Failed to get service %s, %s, %s", ns, svcName, svcPort)
return nil, false, err
}
servicePort, err := svc.getServicePort(svcPort)
if err != nil {
log.Errorf("convertDefaultBackend: Failed to find target port %v, %s, for ingress %s/%s and service %s add shuntroute: %v", svc.Spec.Ports, svcPort, ns, name, svcName, err)
err = nil
} else if svc.Spec.Type == "ExternalName" {
r, err := externalNameRoute(ns, name, "default", nil, svc, servicePort, ing.allowedExternalNames)
return r, err == nil, err
} else {
log.Debugf("convertDefaultBackend: Found target port %v, for service %s", servicePort.TargetPort, svcName)
protocol := "http"
if p, ok := i.Metadata.Annotations[skipperBackendProtocolAnnotationKey]; ok {
protocol = p
}
eps = state.getEndpointsByService(
ns,
svcName,
protocol,
servicePort,
)
log.Debugf("convertDefaultBackend: Found %d endpoints for %s: %v", len(eps), svcName, err)
}
if len(eps) == 0 {
// add shunt route https://github.com/zalando/skipper/issues/1525
log.Debugf("convertDefaultBackend: add shuntroute to return 502 for ingress %s/%s service %s with %d endpoints", ns, name, svcName, len(eps))
r := &eskip.Route{
Id: routeID(ns, name, "", "", ""),
}
shuntRoute(r)
return r, true, nil
} else if len(eps) == 1 {
return &eskip.Route{
Id: routeID(ns, name, "", "", ""),
Backend: eps[0],
BackendType: eskip.NetworkBackend,
}, true, nil
}
return &eskip.Route{
Id: routeID(ns, name, "", "", ""),
BackendType: eskip.LBBackend,
LBEndpoints: eps,
LBAlgorithm: getLoadBalancerAlgorithm(i.Metadata),
}, true, nil
}
func (ing *ingress) ingressRoute(
i *definitions.IngressItem,
redirect *redirectInfo,
state *clusterState,
hostRoutes map[string][]*eskip.Route,
df defaultFilters,
) (*eskip.Route, error) {
if i.Metadata == nil || i.Metadata.Namespace == "" || i.Metadata.Name == "" || i.Spec == nil {
log.Error("invalid ingress item: missing Metadata or Spec")
return nil, nil
}
logger := log.WithFields(log.Fields{
"ingress": fmt.Sprintf("%s/%s", i.Metadata.Namespace, i.Metadata.Name),
})
redirect.initCurrent(i.Metadata)
ic := ingressContext{
state: state,
ingress: i,
logger: logger,
annotationFilters: annotationFilter(i.Metadata, logger),
annotationPredicate: annotationPredicate(i.Metadata),
extraRoutes: extraRoutes(i.Metadata, logger),
backendWeights: backendWeights(i.Metadata, logger),
pathMode: pathMode(i.Metadata, ing.pathMode),
redirect: redirect,
hostRoutes: hostRoutes,
defaultFilters: df,
}
var route *eskip.Route
if r, ok, err := ing.convertDefaultBackend(state, i); ok {
route = r
} else if err != nil {
ic.logger.Errorf("error while converting default backend: %v", err)
}
for _, rule := range i.Spec.Rules {
err := ing.addSpecRule(ic, rule)
if err != nil {
return nil, err
}
}
return route, nil
}