Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verbose error log: URL query contains semicolon #1982

Closed
jbspeakr opened this issue Mar 18, 2022 · 1 comment · Fixed by #1984
Closed

Verbose error log: URL query contains semicolon #1982

jbspeakr opened this issue Mar 18, 2022 · 1 comment · Fixed by #1984

Comments

@jbspeakr
Copy link
Member

Describe the bug
Skipper does not support parsing of URL queries that contain semicolon, but logs an error if clients send semicolons. Logged errors should be actionable, which in this context is not the case since this is something the client does. It's not an error from Skipper's perspective.

Expected behavior
Log level of info would potentially (if a log message is actually required) make more sense in this case.

Observed behavior
with Skipper v0.13.185
time="2022-03-18T09:20:32Z" level=error msg="http: URL query contains semicolon, which is no longer a supported separator; parts of the query may be stripped when parsed; see golang.org/issue/25192\n"

@AlexanderYastrebov
Copy link
Member

golang/go#25192 mentions two others golang/go#49399 and golang/go#50034
To mute the log message (if we decide so) the machinery introduced by #1904 can be used.

AlexanderYastrebov added a commit that referenced this issue Mar 18, 2022
Fixes #1982

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
AlexanderYastrebov added a commit that referenced this issue Mar 21, 2022
Fixes #1982

Signed-off-by: Alexander Yastrebov <alexander.yastrebov@zalando.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants